From 9f5d35f7bab74b5ee5db6ff7cb0a519fc8650e0d Mon Sep 17 00:00:00 2001
From: Arno Kaimbacher <arno.kaimbacher@geosphere.at>
Date: Wed, 19 Mar 2025 13:28:02 +0100
Subject: [PATCH] hotfix: enhance dataset creation and modal styling

- Added `@adonisjs/bodyparser` as a dependency.
- Improved the layout and styling of the consent modal in `Create.vue`.
- Enhanced the placeholder text for reference values in `Create.vue`.
- Added a default empty string for the subject in `Create.vue`.
- Updated the styling of the `CardBoxModal` component.
---
 package-lock.json                             |  1 +
 package.json                                  |  1 +
 resources/js/Components/CardBoxModal.vue      |  4 +-
 .../js/Pages/Submitter/Dataset/Create.vue     | 62 +++++++++++--------
 4 files changed, 40 insertions(+), 28 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 6cf37e3..14d7224 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -9,6 +9,7 @@
       "version": "1.0.0",
       "dependencies": {
         "@adonisjs/auth": "^9.2.4",
+        "@adonisjs/bodyparser": "^10.0.3",
         "@adonisjs/core": "^6.17.0",
         "@adonisjs/cors": "^2.2.1",
         "@adonisjs/drive": "^3.2.0",
diff --git a/package.json b/package.json
index cf45027..07f4e7e 100644
--- a/package.json
+++ b/package.json
@@ -76,6 +76,7 @@
   },
   "dependencies": {
     "@adonisjs/auth": "^9.2.4",
+    "@adonisjs/bodyparser": "^10.0.3",
     "@adonisjs/core": "^6.17.0",
     "@adonisjs/cors": "^2.2.1",
     "@adonisjs/drive": "^3.2.0",
diff --git a/resources/js/Components/CardBoxModal.vue b/resources/js/Components/CardBoxModal.vue
index 6e7f9aa..b0fdf01 100644
--- a/resources/js/Components/CardBoxModal.vue
+++ b/resources/js/Components/CardBoxModal.vue
@@ -61,10 +61,10 @@ const cancel = () => confirmCancel('cancel');
         <CardBox
             v-show="value"
             :title="title"
-            class="shadow-lg max-h-modal w-11/12 md:w-3/5 lg:w-2/5 xl:w-4/12 z-50"
+            class="p-4 shadow-lg max-h-modal w-11/12 md:w-3/5 lg:w-2/5 xl:w-4/12 z-50"
             :header-icon="mdiClose"
             modal
-            @header-icon-click="cancel"
+            @header-icon-click="cancel"            
         >
             <div class="space-y-3">
                 <h1 v-if="largeTitle" class="text-2xl">
diff --git a/resources/js/Pages/Submitter/Dataset/Create.vue b/resources/js/Pages/Submitter/Dataset/Create.vue
index 934c320..8c8373e 100644
--- a/resources/js/Pages/Submitter/Dataset/Create.vue
+++ b/resources/js/Pages/Submitter/Dataset/Create.vue
@@ -98,23 +98,23 @@ const flash: ComputedRef<any> = computed(() => {
 
 // Computed property to determine the placeholder based on the selected option
 const getPlaceholder = computed(() => (type: string) => {
-    
+
     switch (type) {
-            case 'DOI':
-                return 'https://doi.org/10.24341/tethys.236';
-            case 'Handle':
-                return '20.500.12345/67890';
-            case 'ISBN':
-                return '978-3-85316-076-3';
-            case 'ISSN':
-                return '1234-5678';
-            case 'URL':
-                return 'https://example.com';
-            case 'URN':
-                return 'urn:nbn:de:1234-5678';
-            default:
-                return '[VALUE]';
-        }   
+        case 'DOI':
+            return 'https://doi.org/10.24341/tethys.236';
+        case 'Handle':
+            return '20.500.12345/67890';
+        case 'ISBN':
+            return '978-3-85316-076-3';
+        case 'ISSN':
+            return '1234-5678';
+        case 'URL':
+            return 'https://example.com';
+        case 'URN':
+            return 'urn:nbn:de:1234-5678';
+        default:
+            return '[VALUE]';
+    }
 });
 
 const mainService = MainService();
@@ -462,7 +462,7 @@ const onMapInitialized = (newItem: any) => {
        adds a new Keyword
        */
 const addKeyword = () => {
-    let newSubject: Subject = { value: 'test', language: '', type: 'uncontrolled' };
+    let newSubject: Subject = { value: '', language: '', type: 'uncontrolled' };
     //this.dataset.files.push(uploadedFiles[i]);
     form.subjects.push(newSubject);
 };
@@ -499,16 +499,25 @@ Removes a selected keyword
 
 <template>
     <CardBoxModal v-model="isModalActive" title="Einverständniserklärung *">
-        Mit dem Setzen des Hakens bestätige ich hiermit
-        <ul class="list-decimal">
+        <p class="mb-4 text-gray-700">
+            Mit dem Setzen des Hakens bestätige ich hiermit folgende Punkte:
+        </p>
+        <ul class="list-decimal pl-6 space-y-2 text-sm text-gray-600">
             <li>
-                die Data Policy von Tethys RDR sowie die Terms & Conditions von Tethys gelesen und verstanden zu haben
-                (<a href="/docs/HandbuchTethys.pdf" target="_blank">siehe hier</a>)
+                die Data Policy von Tethys RDR sowie die
+                <a href="/docs/HandbuchTethys.pdf" target="_blank"
+                    class="font-medium text-blue-600 hover:text-blue-800 transition-colors underline">
+                    Terms &amp; Conditions
+                </a>
+                von Tethys gelesen und verstanden zu haben.
             </li>
-            <li>das Einverständnis aller Co-Autoren über die bevorstehende Datenpublikation schriftlich eingeholt zu
-                haben
+            <li>
+                das Einverständnis aller Co-Autoren über die bevorstehende Datenpublikation schriftlich eingeholt zu
+                haben.
+            </li>
+            <li>
+                sowohl mit der Data Policy als auch mit den Terms &amp; Conditions einverstanden zu sein.
             </li>
-            <li>sowohl mit der Data Policy als auch mit den Terms & Conditions einverstanden zu sein</li>
         </ul>
     </CardBoxModal>
 
@@ -894,7 +903,7 @@ Removes a selected keyword
 
                         <CardBox class="mb-6 shadow" has-table title="Coverage Information" :icon="mdiEarthPlus">
                             <!-- elevation menu -->
-                            <div class="flex flex-col md:flex-row mb-3 space-y-2 md:space-y-0 md:space-x-4">                             
+                            <div class="flex flex-col md:flex-row mb-3 space-y-2 md:space-y-0 md:space-x-4">
                                 <label for="elevation-option-one" class="pure-radio mb-2 md:mb-0">
                                     <input id="elevation-option-one" type="radio" v-model="elevation" value="absolut" />
                                     absolut elevation (m)
@@ -1071,7 +1080,8 @@ Removes a selected keyword
                                             <!-- <input name="Reference Value" class="form-control"
                                                 placeholder="[VALUE]" v-model="item.value" /> -->
                                             <FormControl required v-model="item.value" :type="'text'"
-                                                :placeholder="getPlaceholder(form.references[index].type)" :errors="form.errors.embargo_date">
+                                                :placeholder="getPlaceholder(form.references[index].type)"
+                                                :errors="form.errors.embargo_date">
                                                 <div class="text-red-400 text-sm"
                                                     v-if="form.errors[`references.${index}.value`] && Array.isArray(form.errors[`references.${index}.value`])">
                                                     {{ form.errors[`references.${index}.value`].join(', ') }}