hotfix(dataset): enhance file download with embargo validation and improve API data handling

- Add embargo date validation to file download process with date-only comparison
- Require first_name for authors/contributors only when name_type is 'Personal'
- Remove sensitive personal data from dataset API responses
- Improve dataset validation logic for better data integrity

app/Controllers/Http/Editor/DatasetController.ts

@@ -605,11 +605,14 @@ export default class DatasetsController {
             doiIdentifier.dataset_id = dataset.id;
             doiIdentifier.type = 'doi';
             doiIdentifier.status = 'findable';
-            // save modified date of datset for re-caching model in db an update the search index
-            dataset.server_date_modified = DateTime.now();
+           
 
             // save updated dataset to db an index to OpenSearch
             try {
+                 // save modified date of datset for re-caching model in db an update the search index
+                dataset.server_date_modified = DateTime.now();
+                // autoUpdate: true only triggers when dataset.save() is called, not when saving a related model like below
+                await dataset.save();
                 await dataset.related('identifier').save(doiIdentifier);
                 const index_name = 'tethys-records';
                 await Index.indexDocument(dataset, index_name);
@@ -900,6 +903,7 @@ export default class DatasetsController {
             const input = request.only(['project_id', 'embargo_date', 'language', 'type', 'creating_corporation']);
             // dataset.type = request.input('type');
             dataset.merge(input);
+            dataset.server_date_modified = DateTime.now();
             // let test: boolean = dataset.$isDirty;
             await dataset.useTransaction(trx).save();