hotfix(dataset): enhance file download with embargo validation and improve API data handling

- Add embargo date validation to file download process with date-only comparison
- Require first_name for authors/contributors only when name_type is 'Personal'
- Remove sensitive personal data from dataset API responses
- Improve dataset validation logic for better data integrity

app/models/person.ts

@@ -1,4 +1,4 @@
-import { column, SnakeCaseNamingStrategy, computed, manyToMany } from '@adonisjs/lucid/orm';
+import { column, SnakeCaseNamingStrategy, computed, manyToMany, afterFetch, afterFind } from '@adonisjs/lucid/orm';
 import { DateTime } from 'luxon';
 import dayjs from 'dayjs';
 import Dataset from './dataset.js';
@@ -95,4 +95,33 @@ export default class Person extends BaseModel {
         pivotColumns: ['role', 'sort_order', 'allow_email_contact'],
     })
     public datasets: ManyToMany<typeof Dataset>;
+
+    // public toJSON() {
+    //     const json = super.toJSON();
+
+    //     // Check if this person is loaded through a pivot relationship with sensitive roles
+    //     const pivotRole = this.$extras?.pivot_role;
+    //     if (pivotRole === 'author' || pivotRole === 'contributor') {
+    //         // Remove sensitive information for public-facing roles
+    //         delete json.email;
+    //         // delete json.identifierOrcid;
+    //     }
+
+    //     return json;
+    // }
+     @afterFind()
+    public static async afterFindHook(person: Person) {
+        if (person.$extras?.pivot_role === 'author' || person.$extras?.pivot_role === 'contributor') {
+            person.email = undefined as any;
+        }
+    }
+
+    @afterFetch()
+    public static async afterFetchHook(persons: Person[]) {
+        persons.forEach(person => {
+            if (person.$extras?.pivot_role === 'author' || person.$extras?.pivot_role === 'contributor') {
+                person.email = undefined as any;
+            }
+        });
+    }
 }